Conversation
Member
Author
|
論理削除だと少し遅い |
うまく動かない(原因調査中)
There was a problem hiding this comment.
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach
forEachでは、thisObjectを二番目の引数で指定することができます。
thisの参照を増やさないで、この機能は積極的に使っていきましょう
Member
Author
There was a problem hiding this comment.
なるほど,ありがとうございます。
この部分は,下のコードをbabelで変換したら出てきたのもので,アロー関数を使えば上手くthisを補足してくれるものと思っていたのですが,
appLoad () {
miil_categories.forEach(cate => {
if (cate.category_id !== 588 && cate.category_id !== 589) {
this.parseMiilCategories(cate, [this.getNodeIdxById('miilroot')]);
}
});
this.drawGraph();
}やはり,
arr.forEach(elem, self => { });という2引数で書いた方が良いということですね。
There was a problem hiding this comment.
なるほど、babelで変換したのですね。
通常は、そういう場合for of構文を使います。
https://developer.mozilla.org/ja/docs/Web/JavaScript/Reference/Statements/for...of
[1, 2, 3].forEach(elem => console.log(this.a));は、
for (let elem of [1,2,3]) {
console.log(this.a);
}と同値です。インデックスをとらないようなforEachをbabelで使うときは、for ofを使っていきましょう。
ついでに、forEachよりJSではインデックスアクセスの方がArrayオブジェクトにとっては効果的(まず、関数オブジェクトがforEachは必ず作成されますし、関数呼び出しのオーバーヘッドもかかるので)なため、for ofの場合、for(var i = 0; ...) { ... }といった感じで変換されます。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.