-
Notifications
You must be signed in to change notification settings - Fork 370
Add WorkspaceFoldersClientCapabilites
#1627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2e4dde6 to
87aa6ea
Compare
workspace/didChangeWorkspaceFolders notificationWorkspaceFoldersClientCapabilites
87aa6ea to
e90ae92
Compare
|
@MariaSolOs can you explain why you think this is necessary. The assumption was always that if a client has support for workspace folders it also supports change notifications. If we add the client capability it might break existing servers since they instead of a |
My main motivation here is being able to announce client support for dynamically registering to receive |
|
I think we should still be able to allow for registering without breaking servers. We could offer a different route for this if it is necessary. |
Fair enough. I'm open to suggestions on how to include the necessary |
Dozamecik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gh pr checkout 1627
Closes microsoft/language-server-protocol#2133
Complements microsoft/language-server-protocol#2134 which contains the respective updates to the specification.