-
Notifications
You must be signed in to change notification settings - Fork 336
Add support for OAS 3.2 nested tags via parent field in @tagMetadata #9577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
10
commits into
main
Choose a base branch
from
copilot/add-oas-32-nested-tags-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+98
−8
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
b69828a
Initial plan
Copilot 9bc8c46
Add support for parent field in @tagMetadata decorator
Copilot 4aaaef7
Update documentation with parent field example
Copilot d9e4bfd
Remove unnecessary type assertions in tag parent conversion
Copilot c831ac7
Add generated documentation files for parent field
Copilot 2cd4f77
Merge main branch and resolve conflicts
Copilot 46dd9d9
Merge branch 'main' into copilot/add-oas-32-nested-tags-support
timotheeguerin da7c83a
Drop parent field for OpenAPI 3.0/3.1 instead of converting to x-parent
Copilot d9d851c
Update tagmetadata.test.ts
timotheeguerin 6facdb9
Run pnpm format to fix formatting issues
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| import { deepStrictEqual } from "assert"; | ||
| import { expect, it } from "vitest"; | ||
| import { supportedVersions, worksFor } from "./works-for.js"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { OpenAPISpecHelpers, supportedVersions, worksFor } from "./works-for.js"; | ||
|
|
||
| worksFor(supportedVersions, ({ openApiFor, openapisFor }) => { | ||
| const testCases: [string, string, string, any][] = [ | ||
|
|
@@ -150,3 +150,79 @@ worksFor(supportedVersions, ({ openApiFor, openapisFor }) => { | |
| ]); | ||
| }); | ||
| }); | ||
|
|
||
| // Test for parent field - version specific behavior | ||
| describe("tag metadata with parent field", () => { | ||
| it("OpenAPI 3.2 should emit parent field as-is", async () => { | ||
| const res = await OpenAPISpecHelpers["3.2.0"].openApiFor( | ||
| ` | ||
| @service | ||
| @tagMetadata("ParentTag", #{description: "Parent tag"}) | ||
| @tagMetadata("ChildTag", #{description: "Child tag", parent: "ParentTag"}) | ||
| namespace PetStore { | ||
| @tag("ChildTag") op test(): string; | ||
| } | ||
| `, | ||
| ); | ||
|
|
||
| deepStrictEqual(res.tags, [ | ||
| { | ||
| name: "ChildTag", | ||
| description: "Child tag", | ||
| parent: "ParentTag", | ||
| }, | ||
| { | ||
| name: "ParentTag", | ||
| description: "Parent tag", | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
| it("OpenAPI 3.1 should drop parent field", async () => { | ||
| const res = await OpenAPISpecHelpers["3.1.0"].openApiFor( | ||
| ` | ||
| @service | ||
| @tagMetadata("ParentTag", #{description: "Parent tag"}) | ||
| @tagMetadata("ChildTag", #{description: "Child tag", parent: "ParentTag"}) | ||
| namespace PetStore { | ||
| @tag("ChildTag") op test(): string; | ||
| } | ||
| `, | ||
| ); | ||
|
|
||
| deepStrictEqual(res.tags, [ | ||
| { | ||
| name: "ChildTag", | ||
| description: "Child tag", | ||
| }, | ||
| { | ||
| name: "ParentTag", | ||
| description: "Parent tag", | ||
| }, | ||
| ]); | ||
| }); | ||
|
|
||
| it("OpenAPI 3.0 should drop parent field", async () => { | ||
| const res = await OpenAPISpecHelpers["3.0.0"].openApiFor( | ||
| ` | ||
| @service | ||
| @tagMetadata("ParentTag", #{description: "Parent tag"}) | ||
| @tagMetadata("ChildTag", #{description: "Child tag", parent: "ParentTag"}) | ||
| namespace PetStore { | ||
| @tag("ChildTag") op test(): string; | ||
| } | ||
| `, | ||
| ); | ||
|
|
||
| deepStrictEqual(res.tags, [ | ||
| { | ||
| name: "ChildTag", | ||
| description: "Child tag", | ||
| }, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this have |
||
| { | ||
| name: "ParentTag", | ||
| description: "Parent tag", | ||
| }, | ||
| ]); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this have
X-Parent?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided not too, and just dropped and would add it if someone asked with options.