Skip to content

Conversation

@rgknp
Copy link

@rgknp rgknp commented Oct 8, 2025

Introduced OpenIddict validation configuration, enabling the use of a local OpenIddict server instance and ASP.NET Core host integration. Replaced services.AddAuthentication with services.PostConfigure<AuthenticationOptions> to delegate authentication setup to the SecurityModule and avoid overriding default schemes.

Updated AddAuthenticationLibrary in Startup.cs to conditionally skip JWT Bearer registration when OpenIddict is enabled or a test authentication environment is configured. Removed OpenIddictAuthorizationController registration and added necessary using directives for OpenIddict and options configuration.

These changes improve authentication flexibility and modularity, particularly for development environments running in containers.

Description

Describe the changes in this PR.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

Introduced OpenIddict validation configuration, enabling the use of a local OpenIddict server instance and ASP.NET Core host integration. Replaced `services.AddAuthentication` with `services.PostConfigure<AuthenticationOptions>` to delegate authentication setup to the `SecurityModule` and avoid overriding default schemes.

Updated `AddAuthenticationLibrary` in `Startup.cs` to conditionally skip JWT Bearer registration when OpenIddict is enabled or a test authentication environment is configured. Removed `OpenIddictAuthorizationController` registration and added necessary `using` directives for OpenIddict and options configuration.

These changes improve authentication flexibility and modularity, particularly for development environments running in containers.
@rgknp rgknp requested a review from a team as a code owner October 8, 2025 20:07
@rgknp
Copy link
Author

rgknp commented Oct 10, 2025

Issue created
#5188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant