Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/definitions-parser/src/packages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,7 @@ export class TypingsData extends PackageBase {
));
}
get projectName(): string | undefined {
return this.data.header.projects[0];
return this.data.header.projects.length === 0 ? undefined : this.data.header.projects.join(", ");
}
get type() {
return this.data.type;
Expand Down
36 changes: 36 additions & 0 deletions packages/definitions-parser/test/packages.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,42 @@ describe(TypingsData, () => {
expect(data.isNotNeeded()).toBe(false);
});

describe("project", () => {
it("returns the name of the only project", () => {
expect(data.projectName).toBe("zombo.com");
});

it("returns multiple project names as a comma-separated string", () => {
const versions = createTypingsVersionRaw(
"known",
{},
{},
{},
{
projects: ["zombo.com", "zombo.org"],
},
);
data = new TypingsData(createMockDT().fs, versions["1.0"], false);

expect(data.projectName).toBe("zombo.com, zombo.org");
});

it("returns undefined if no project is set", () => {
const versions = createTypingsVersionRaw(
"known",
{},
{},
{},
{
projects: [],
},
);
data = new TypingsData(createMockDT().fs, versions["1.0"], false);

expect(data.projectName).toBeUndefined();
});
});

describe("desc", () => {
it("returns the name if latest version", () => {
expect(data.desc).toBe("@types/known");
Expand Down
4 changes: 3 additions & 1 deletion packages/definitions-parser/test/utils.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { License } from "@definitelytyped/header-parser";
import { Header, License } from "@definitelytyped/header-parser";
import { TypingsVersionsRaw, getMangledNameForScopedPackage } from "../src/packages";
import { atTypesSlash } from "@definitelytyped/utils";

Expand All @@ -13,6 +13,7 @@ export function createTypingsVersionRaw(
dependencies: { readonly [name: string]: string },
devDependencies: { readonly [name: string]: string },
peerDependencies?: { readonly [name: string]: string },
headerOverrides: Partial<Header> = {},
): TypingsVersionsRaw {
return {
"1.0": {
Expand All @@ -25,6 +26,7 @@ export function createTypingsVersionRaw(
nonNpm: false,
projects: ["zombo.com"],
tsconfigs: ["tsconfig.json"],
...headerOverrides,
},
typesVersions: [],
license: License.MIT,
Expand Down
Loading