[Bugfix] Fix VERSION FileNotFoundError bugs via pip installation#285
[Bugfix] Fix VERSION FileNotFoundError bugs via pip installation#285LeiWang1999 merged 3 commits intomicrosoft:mainfrom
Conversation
|
�thanks @senlyu163 for your awesome contributions! I think it’s still important to maintain a VERSION text file in the root of the project to clearly indicate the version. A better solution might be to modify version.py to detect the paths of two VERSION files. If one of them is missing, we can fall back to the other. This approach ensures flexibility while keeping the versioning clear and consistent. And that way is more aligned with the UNIX design philosophy. |
Thanks for your review. I will re-commit based on your suggestions. |
… pip" This reverts commit 3fcedba.
|
Hi, lei. I've made changes to the PR based on your previous comments. Could you please review the changes again and let me know if this makes sense? |
|
thanks for your awesome contribution! LGTM, Merged :) |
This pr fix version bugs via pip installation. It can reproduce by
pip install git+https://github.com/microsoft/BitBLAS.gitAfter installing BitBLAS, verify the installation by running:
This bug occurs because during the pip installation, the VERSION file is copied to
/usr/local/lib/python3.10/dist-packages/bitblas/VERSION, while theversion.pyfile reads from an incorrect path.Improvement: Consolidate the version number management of BitBLAS by placing it directly into the
version.pyfile.Please cc: @LeiWang1999