Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds two statistical testing methods for differential abundance analysis: Wilcoxon rank-sum test and t-test (Welch's and Student's variants). The implementation includes both getter functions that return test results and adder functions that store results directly in the object's metadata.
Key changes:
- Added
getWilcoxon()/addWilcoxon()for non-parametric testing - Added
getTtest()/addTtest()for parametric testing - Created unified internal DAA engine with error handling and p-value adjustment
- Comprehensive test suite with validation, robustness, and paired data tests
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| vignettes/daa.Rmd | Simplified vignette with examples of the new Wilcoxon and t-test methods |
| README.md / README.Rmd | Updated documentation to describe available methods and usage |
| R/AllGenerics.R | Defines S4 generics for the new statistical testing functions |
| R/utils.R | Implements input validation, data extraction, and unified DAA engine |
| R/getWilcoxon.R | Implements Wilcoxon rank-sum test with S4 methods |
| R/getTtest.R | Implements t-test with S4 methods and var.equal parameter |
| tests/testthat/test-*.R | Comprehensive test coverage for utility functions and both statistical methods |
| DESCRIPTION | Updated dependencies and RoxygenNote version |
| NAMESPACE | Auto-generated exports for new functions |
| man/*.Rd | Auto-generated documentation files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.