Add full screen recording#67
Conversation
Signed-off-by: fangzheng <fz0000@sina.com>
|
Thanks for the contributing! Sorry for the delayed response. I'm not opposed to this, however, there should be some kind of warning to let the user know that the recording might not turn out as expected with a high resolution (such as low FPS, stutter, etc.) when switched to the fullscreen mode There is a warning button that appears although I think it would be rendered useless when the main form is minimized. Perhaps some sort of "Are you sure?" with a remember option. Thoughts on this? https://github.com/thetarkus/WebMCam/blob/22d96602894a83679e19a3fe4b74fef5cf643dbf/FormMain.cs#L438 |
|
Yes I don't recommend recording in high resolution, either. 😅 This is how the story goes: our display is only 17" (1280 x 1024) and we don't need the demo video to be that fluent. So we set the fps to 3 and the output is acceptable for us. I think the pop up message is a good idea since many users might ignore the warning button. And we can also reduce the default FPS value (e.g. to 5 or 10) when user resize the box to a large size or select the full screen recording option. Moreover, we can give a double warning when user click the record button... |
I found that there was a request for this feature: #48
My team member asked for this feature today, too. (We just need a small and simple tool so They prefer WebMCam to OBS...)
So I just add the options.
The most important changes are in the file
FormMain.cs(andFormMain.Designer.cs). My platform is VS2017 so many other files are also changed. 😅