[MOO-2155] - Fix file not found exception #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karahanharunn
previously approved these changes
Dec 8, 2025
Contributor
karahanharunn
left a comment
karahanharunn
left a comment
There was a problem hiding this comment.
Vadym already mentioned that, guard fileManager.fileExists(atPath: filepath) else { return } code throws error without any logging. We can add log if it fails.
Collaborator
Author
This does not throw any error, instead it returns and resolves promise. Added a log for this scenario before returning. |
Co-authored-by: vadymv-mendix <138661748+vadymv-mendix@users.noreply.github.com>
vadymv-mendix
previously approved these changes
Dec 8, 2025
karahanharunn
previously approved these changes
Dec 8, 2025
YogendraShelke
dismissed stale reviews from karahanharunn and vadymv-mendix
via
5e101df
vadymv-mendix
previously approved these changes
Dec 9, 2025
karahanharunn
previously approved these changes
Dec 9, 2025
YogendraShelke
dismissed stale reviews from karahanharunn and vadymv-mendix
via
93dbe78
vadymv-mendix
approved these changes
Dec 9, 2025
karahanharunn
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.