Open
Conversation
Owner
|
conflicts caused by other merge, please try again |
|
We could use this change. @mfowlewebs do you have time to re-submit it? Otherwise, we can open another PR without the merge conflict. I'm not sure what the conflict is, but looking at the code, it must be a relatively straight-forward resolution. |
Author
|
@memorycraft i've updated the branch, ought be merge free. would appreciate this getting merged in. many thanks for the fine plugin!! |
|
@mfowlewebs I took your fix and merged it into my fork. I also published a new gem |
Author
|
Thanks for the note! And thanks for the publish- that helped us. 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7, possible infinite loop of sending a single log statement.