Specify yarn classic as PM for js-sdk wrapper#226
Merged
Conversation
richvdh
approved these changes
Feb 17, 2026
| "vite": "^5.4.21" | ||
| } | ||
| }, | ||
| "packageManager": "yarn@1.22.22" |
Member
There was a problem hiding this comment.
do we have to pin it to a specific version?
Member
Author
There was a problem hiding this comment.
yarn classic 1.x behaves extremely differently from yarn berry 4.x so I recommend doing so even if it is not necessary. The yarn.lock is generated by yarn classic, so using yarn berry would make an incompatible lockfile. https://github.com/matrix-org/complement-crypto/blob/main/internal/api/js/js-sdk/yarn.lock#L2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #225
Without this, in CI, js-sdk downstream tests fail due to
complement-cryptobeing checked out withinmatrix-js-sdk, and thus inheriting its packageManager definition ofpnpm