Hide "Open Folder..." command from Default package#83
Open
rchl wants to merge 2 commits intomath2001:masterfrom
Open
Hide "Open Folder..." command from Default package#83rchl wants to merge 2 commits intomath2001:masterfrom
rchl wants to merge 2 commits intomath2001:masterfrom
Conversation
|
|
Author
|
Nah, it opens a finder window: Screen.Recording.2025-05-04.at.12.01.10.movBut this repo seems dead so I don't see this being addressed anyway |
|
My mistake, I was thinking of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileManager didn't hide the built-in
OpenFolderCommand(Open Folder...) even though it provides its own equivalent (Open in Finder).It did hide the built-in
OpenContainingFolderCommandalready so I'm guessing that this was just an omission.The small change in imports is due to pyright type-checker reporting that class can't inherit itself. It might have worked in practice but I think this is more explicit and clear with my change.