base64 values should be decoded with proper encodings#150
Open
risperdal wants to merge 2 commits intomartomo:masterfrom
risperdal:master
Open
base64 values should be decoded with proper encodings#150risperdal wants to merge 2 commits intomartomo:masterfrom risperdal:master
risperdal wants to merge 2 commits intomartomo:masterfrom
risperdal:master
Conversation
….decode('utf8')
which is a strict mode.
base64 values should be decoded with proper encodings
Author
|
To reproduce issue utf8.php (save with encoding utf-8) <?php
$utf_str = "ç ı ü ğ ö ş İ Ğ Ü Ö Ş Ç";
echo $utf_str;
include "win1254.php";
?>save it to same folder <?php
$deneme = array('ÇOK GÜZELMİŞ' => 'şanlıurfa'); //put breakpoint here
$win1254_str = "ç ı ü ğ ö ş İ Ğ Ü Ö Ş Ç";
echo $win1254_str;
?>put a breakpoint to win1254.php line 1 |
Author
|
should solve issue #110 |
even it was in try except block
|
I would like to merge your fixes into my fork: Would you mind rebasing them against the I am attempting to get my fork into Package Control: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base64 values should be decoded with proper encodings
base64 properties was always been decoded with base64.b64decode(data).decode('utf8')
which is a strict mode. It throws UnicodeDecodeError exception when the property value is not UTF-8