MLE-24733 Deleting custom deployer for tests#1020
Closed
Conversation
rjrudin
requested review from
BillFarber,
anu3990 and
stevebio
as code owners
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR removes custom test deployment infrastructure as part of ticket MLE-24733, streamlining test setup by eliminating the custom deployer previously used for tests.
Key changes:
- Removed the
test-complete-appdirectory containing custom Gradle-based deployment configuration - Deleted multiple test setup, teardown, and configuration scripts from the
etcdirectory - Removed the
config-opticdirectory with its QA setup infrastructure and test data files
Reviewed Changes
Copilot reviewed 71 out of 73 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test-complete-app/* | Removed entire custom Gradle deployment directory including server configs, certificate templates, and wrapper scripts |
| etc/test-*.js | Deleted test setup/teardown scripts and user configuration utilities |
| etc/data/* | Removed test data files including TDE templates, validation schemas, and transform scripts |
| config-optic/* | Deleted optic test configuration, setup scripts, and extensive test data files |
| package.json | Removed test-related npm scripts (setup, teardown, test) |
| test-basic/rows.js | Removed outdated comment reference |
| etc/test-setup-prompt.js | Cleaned up TODO comments about ml-gradle migration |
| .npmignore | Removed test-complete-app directory from npm ignore list |
| .copyrightconfig | Updated file exclusion list to remove test-complete-app reference |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rjrudin
force-pushed
the
feature/delete-custom-deployer
branch
from
2744301 to
358c654
Compare
Not deleting data files for now.
rjrudin
force-pushed
the
feature/delete-custom-deployer
branch
from
358c654 to
f6ad7f0
Compare
Contributor
Author
|
Closing this, will try a new PR since this node seems cooked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.