MLE-26918 Added fromView support for incremental write

[rjrudin]

The plan is to dump eval support and just offer fromLexicons and fromView, but need to test out fromView a bit first.

[github-actions]

Copyright Validation Results
Total: 7 | Passed: 6 | Failed: 0 | Skipped: 1 | at: 2026-02-10 19:39:58 UTC | commit: 130ba68

⏭️ Skipped (Excluded) Files

• test-app/src/main/ml-schemas/tde/incrementalWriteHash.json

✅ Valid Files

• marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteConfig.java
• marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteEvalFilter.java
• marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java
• marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteOpticFilter.java
• marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteViewFilter.java
• marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteTest.java

✅ All files have valid copyright headers!

[Copilot]

Pull request overview

Adds support for incremental write hashing via an Optic fromView query (TDE view) as an alternative to lexicon-based retrieval, along with tests and a sample TDE template.

Changes:

• Added a new IncrementalWriteViewFilter implementation that queries existing hashes from a TDE view via op.fromView.
• Extended IncrementalWriteFilter.Builder with fromView(schemaName, viewName) and wiring in build().
• Added test coverage for successful fromView usage and for a helpful failure when the view is invalid; added a sample TDE template for the view.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
test-app/src/main/ml-schemas/tde/incrementalWriteHash.json	Adds a TDE template to expose URI/hash via a view used by fromView.
marklogic-client-api/src/test/java/com/marklogic/client/datamovement/filter/IncrementalWriteTest.java	Adds tests for fromView and invalid view failure messaging.
marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteViewFilter.java	Implements view-based hash lookup using RowTemplate + Optic fromView.
marklogic-client-api/src/main/java/com/marklogic/client/datamovement/filter/IncrementalWriteFilter.java	Adds builder support for configuring and constructing the view-based filter.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The rethrown FailedRequestException drops the original exception as the cause, which makes debugging harder (stack trace/cause chain is lost). Prefer a constructor overload that accepts the cause, or initialize the cause on the newly created exception so the original e is preserved.

Suggested change

	throw new FailedRequestException(message, e.getFailedRequest());
	FailedRequestException fre = new FailedRequestException(message, e.getFailedRequest());
	fre.initCause(e);
	throw fre;

[Copilot]

This JSON uses tab indentation. If the repo’s JSON/style conventions prefer spaces (common for JSON), consider normalizing indentation to match the rest of the project to reduce noisy diffs and keep formatting consistent.

Suggested change

	"template": {
	"description": "For incremental write that uses op.fromView instead of op.fromLexicons",
	"context": "/doc",
	"rows": [
	{
	"schemaName": "javaClient",
	"viewName": "incrementalWriteHash",
	"columns": [
	{
	"name": "uri",
	"scalarType": "string",
	"val": "xdmp:node-uri(.)"
	},
	{
	"name": "hash",
	"scalarType": "string",
	"val": "xdmp:node-metadata-value(., 'incrementalWriteHash')",
	"nullable": true
	}
	]
	}
	]
	}
	"template": {
	"description": "For incremental write that uses op.fromView instead of op.fromLexicons",
	"context": "/doc",
	"rows": [
	{
	"schemaName": "javaClient",
	"viewName": "incrementalWriteHash",
	"columns": [
	{
	"name": "uri",
	"scalarType": "string",
	"val": "xdmp:node-uri(.)"
	},
	{
	"name": "hash",
	"scalarType": "string",
	"val": "xdmp:node-metadata-value(., 'incrementalWriteHash')",
	"nullable": true
	}
	]
	}
	]
	}