-
Notifications
You must be signed in to change notification settings - Fork 74
PDP-817: Added support to execute regressions on arm infrastructure #1891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Copyright Validation Results ⏭️ Skipped (Excluded) Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for running regression tests on ARM-based infrastructure. When the arm_regressions parameter is enabled, the pipeline provisions ARM EC2 instances, configures them with necessary dependencies, and executes tests against ARM-compatible MarkLogic images.
Changes:
- Added ARM platform support with conditional logic based on
arm_regressionsparameter - Introduced new pipeline stages for provisioning ARM infrastructure and running tests
- Updated Docker Compose configuration to support both ARM and AMD64 platforms
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docker-compose.yaml | Made platform and converter settings configurable via environment variables to support ARM |
| Jenkinsfile | Added ARM regression parameter, infrastructure provisioning stage, ARM-specific test execution, and cleanup logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Taken care of suggesions |
rjrudin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please redo the edits with the .editorconfig file applied - Copilot should be able to help with that. That file specifies that indents are tabs and not spaces. Ideally that would be spaces, but this is an older editorconfig file that we haven't switched over to spaces yet.
fcfad83 to
4956461
Compare
SameeraPriyathamTadikonda
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, will approve this PR once the dependent PRs are merged to avoid failures.
The changes made to the jenkinsfile to support
provision arm based infrastructure and execute regressions on arm ec2 instance when arm_regressions parameter is enabled
Jenkins console log for arm regressions
https://ml-clt-jenkins.progress.com/job/devexp/job/Java-Client/job/java-client-api-regression/job/arm-regressions-testbranch/108/console