MLE-26428 Added timestamp to metadata for incremental write#1871
Merged
MLE-26428 Added timestamp to metadata for incremental write#1871
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds timestamp tracking to the incremental write functionality by storing a timestamp alongside the hash value in document metadata. The changes ensure that each document written through the incremental write filter captures both when it was written (timestamp) and its content signature (hash).
Key changes:
- Renamed
fieldNametohashKeyNamethroughout the codebase to better reflect that it's a metadata key, not a field name - Added
timestampKeyNameparameter with default value "incrementalWriteTimestamp" to track when documents are written - Updated the
addHashToMetadatamethod to accept and store both hash and timestamp values
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| IncrementalWriteFilter.java | Core changes: renamed field parameter, added timestamp key parameter, and updated metadata storage to include timestamp |
| IncrementalWriteOpticFilter.java | Updated constructor and field reference to use new hashKeyName parameter |
| IncrementalWriteEvalFilter.java | Updated constructor and JavaScript eval script to use hashKeyName instead of fieldName |
| IncrementalWriteFilterTest.java | Added test assertions to verify timestamp is correctly added to metadata |
| IncrementalWriteTest.java | Updated method calls to use hashKeyName and added timestamp validation in verification method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
BillFarber
approved these changes
Dec 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.