MLE-25959 Deprecating AUTH_TYPE_MARKLOGIC_CLOUD

[rjrudin]

Should have renamed this in a prior release.

[github-actions]

Copyright Validation Results
Total: 2 | Passed: 2 | Failed: 0 | Skipped: 0 | at: 2025-12-11 18:32:30 UTC | commit: f0d4fdd

✅ Valid Files

• marklogic-client-api/src/main/java/com/marklogic/client/DatabaseClientBuilder.java
• marklogic-client-api/src/main/java/com/marklogic/client/impl/DatabaseClientPropertySource.java

✅ All files have valid copyright headers!

[Copilot]

Pull request overview

This PR deprecates the AUTH_TYPE_MARKLOGIC_CLOUD constant in favor of the shorter AUTH_TYPE_CLOUD constant. The change maintains backward compatibility by keeping the deprecated constant while updating internal references to use the new naming convention.

Key changes:

• Introduced AUTH_TYPE_CLOUD as the new constant and deprecated AUTH_TYPE_MARKLOGIC_CLOUD
• Updated all internal usages to reference AUTH_TYPE_CLOUD instead of the deprecated constant

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
DatabaseClientBuilder.java	Introduced new AUTH_TYPE_CLOUD constant, deprecated AUTH_TYPE_MARKLOGIC_CLOUD, and updated methods to use the new constant
DatabaseClientPropertySource.java	Updated switch case and conditional logic to reference AUTH_TYPE_CLOUD instead of deprecated constant

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The deprecated constant AUTH_TYPE_MARKLOGIC_CLOUD should be updated to point to the new constant AUTH_TYPE_CLOUD to ensure consistency. Consider changing its value from \"cloud\" to reference AUTH_TYPE_CLOUD directly (e.g., AUTH_TYPE_MARKLOGIC_CLOUD = AUTH_TYPE_CLOUD). This ensures both constants remain synchronized if the underlying value ever needs to change.

Suggested change

	public final static String AUTH_TYPE_MARKLOGIC_CLOUD = "cloud";
	public final static String AUTH_TYPE_MARKLOGIC_CLOUD = AUTH_TYPE_CLOUD;