Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates JUnit from version 5.11.1 to 5.13.4 and addresses related Gradle compatibility issues. The changes also include upgrading the Gradle wrapper to version 8.14.3.
- Updates JUnit Jupiter dependency to version 5.13.4 across test modules
- Adds required junit-platform-launcher dependency to fix test discovery issues with JUnit 5.12+
- Updates Gradle wrapper from 8.13 to 8.14.3 with enhanced configuration
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| marklogic-client-api/build.gradle | Updates JUnit version and uncomments junit-platform-launcher dependency |
| marklogic-client-api-functionaltests/build.gradle | Updates JUnit version and adds junit-platform-launcher dependency |
| gradlew.bat | Updated Gradle wrapper script with improved error handling and execution method |
| gradlew | Updated Gradle wrapper script with modernized shell scripting and execution method |
| gradle/wrapper/gradle-wrapper.properties | Updates Gradle distribution to 8.14.3 with additional validation settings |
| esac | ||
|
|
||
| CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar | ||
| CLASSPATH="\\\"\\\"" |
There was a problem hiding this comment.
The CLASSPATH is set to escaped quotes which appears incorrect. This should likely be an empty string or properly escaped empty quotes for the classpath.
Suggested change
| CLASSPATH="\\\"\\\"" | |
| CLASSPATH="" |
BillFarber
previously approved these changes
Jul 23, 2025
rjrudin
force-pushed
the
feature/junit-upgrade
branch
2 times, most recently
from
8bebdae to
3f7b563
Compare
Brought back fix for Gradle deprecation warning as well. Updated Gradle wrapper to latest version too - 8.14.3. And gave up on trying to ignore Spring dependencies from marklogic-junit5 - just cloned the one class we need.
rjrudin
force-pushed
the
feature/junit-upgrade
branch
from
3f7b563 to
ca0c6fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brought back fix for Gradle deprecation warning as well. Updated Gradle wrapper to latest version too - 8.14.3.