fix: add --workspaces-update=false to npm version for npm 11 compatibility #906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility npm 11's arborist has issues with bun's workspace symlinks in node_modules. This flag prevents npm from walking the workspace tree during version bump.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Release CI workflow failing with
npm error Cannot read properties of null (reading 'matches')duringnpm versionstep.Problem
After upgrading to Bun 1.3, the lockfile format changed to
configVersion: 1which records workspace dependencies asworkspace:*symlinks. npm 11's arborist has issues walking this node_modules structure, causingnpm versionto fail.Solution
Add
--workspaces-update=falseto thenpm.versionArgsin release-it config. This prevents npm from walking the workspace tree during version bump. The@release-it/bumperplugin already handles updatingexample/package.jsonexplicitly.Changes
versionArgs: ["--workspaces-update=false"]to release-it npm configTesting
Merge and run Release workflow with dry-run enabled to verify
npm versionsucceeds.