Formatter: Fix ERB text flow formatting to keep adjacent inline elements together#1010
Open
ydah wants to merge 1 commit intomarcoroth:mainfrom
Open
Formatter: Fix ERB text flow formatting to keep adjacent inline elements together#1010ydah wants to merge 1 commit intomarcoroth:mainfrom
ydah wants to merge 1 commit intomarcoroth:mainfrom
Conversation
|
Really nice feature :) |
marcoroth
changed the title
marcoroth
reviewed
Feb 13, 2026
| <strong>Bold Heading:</strong><br> | ||
| <%= Date.current %>: Lorem ipsum dolor sit amet, consectetur adipiscing | ||
| elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. | ||
| <strong>Bold Heading:</strong><br> <%= Date.current %>: Lorem ipsum |
Owner
There was a problem hiding this comment.
The idea was that a <br> tag would also break the line in the text flow. I feel like it would be great if we could keep that behavior here.
marcoroth
reviewed
Feb 13, 2026
Comment on lines
+558
to
+560
| expect(result).not.toContain(`<%= foo %>\n sed`) | ||
| expect(result).not.toContain(`<%= bar %>\n .`) | ||
| expect(result).toContain(`<%= bar %>. Lorem`) |
Owner
There was a problem hiding this comment.
Can we assert the full result here using toBe?
marcoroth
reviewed
Feb 13, 2026
| const source = `<p><strong>Summary:</strong><br> Lorem ipsum <%= foo %> dolor <%= bar %>. Sit amet...</p>` | ||
| const result = formatter.format(source) | ||
|
|
||
| expect(result).not.toContain(`<%= bar %>\n.`) |
Owner
There was a problem hiding this comment.
Can we assert the full result here using toBe?
marcoroth
reviewed
Feb 13, 2026
Comment on lines
+515
to
+516
| expect(result).not.toContain(`<%= foo %>\n`) | ||
| expect(result).not.toContain(`<%= bar %>\n .`) |
Owner
There was a problem hiding this comment.
Can we assert the full result here using toBe?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #903