fix: wrong InjectorContext scope set in HTTP, and wrong received in RPC#673
Merged
fix: wrong InjectorContext scope set in HTTP, and wrong received in RPC#673
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes incorrect InjectorContext scope behavior in HTTP and RPC contexts by removing the misleading RpcInjectorContext class and ensuring proper scoped injection of InjectorContext across different contexts.
- Removes the
RpcInjectorContextclass that was causing misleading behavior - Configures proper scoped
InjectorContextproviders for both RPC and HTTP contexts - Updates the injector system to correctly set and retrieve scoped injector contexts
- Adds comprehensive tests to verify correct injector context scoping behavior
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/rpc/src/server/kernel.ts | Adds InjectorContext provider to RPC scope and sets injector context properly |
| packages/http/src/module.ts | Adds scoped InjectorContext provider to HTTP module configuration |
| packages/http/src/http.ts | Updates setter call to use string scope name instead of scope object |
| packages/injector/src/injector.ts | Refactors setter methods to accept scope names and improves scope handling |
| packages/framework/src/*.ts | Removes RpcInjectorContext references and updates to use InjectorContext |
| test files | Updates tests to use InjectorContext instead of RpcInjectorContext |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Removed RpcInjectorContext due to highly misleading behaviour. It's now possible to inject InjectorContext in the different scopes with correct expectations (to get the scoped injector context).
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Ventrae
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed RpcInjectorContext due to highly misleading behaviour. It's now possible to inject InjectorContext in the different scopes with correct expectations (to get the scoped injector context).
Summary of changes
Relinquishment of Rights
Please mark following checkbox to confirm that you relinquish all rights of your changes: