Mapnik v3.1.0 extend #164
Draft
Mapnik v3.1.0 extend #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update links and refer to datasources explicitly
Update README
Refers to mapnik PR #3512
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft attempt to document PR #3512.
Queries:
expressions: trueneeds checking. I didn't know how to determine from the code whether expressions would be supported.extendkey is parsed inparse_symbolizer_base, which is used by multiple symbolizers rather than just Line. Is this correct? But presumably it only makes sense to documentextendfor the line symbolizer?I would like to have a way to double-check that a given property is present in 3.1.0. I would have expected "extend" to be found when using
strings libmapnik.so.3.1.0, but it drew a blank. I triedscripts/validate_mapnik_instance.py, but I don't think this will work unless the python bindings match 3.1.0 (which they didn't seem to).I do think it would be helpful to retrospectively create an approximate entry in the mapnik
CHANGELOG.mdto separate out then changes up to 3.1. It looks like everything after 3.0.20 has been lumped under the 4.0.0 entry?