Open
Conversation
Author
|
Now with 1.15 update :) |
Previously only the support was rendered, now the bell is displayed too
- namespace have been added in some files, and should be removed to furthur process the asset - Walls have now new properties that must be explicitly set.
elamperti
approved these changes
Jun 28, 2020
Collaborator
|
@m0r13 This PR has changes in |
|
@elamperti @m0r13 if you guys accept this can you please also be sure to update the published docker image? |
Collaborator
|
@fredkilbourn I think build are not automated for this repo so we'll have to keep an eye on that. I'd like that to be fixed but I'll focus efforts on merging |
|
No problem thanks! |
This issue solves the green tints on: * mushroom stems * warped stems * stripped warped stems * crimson stems * stripped crimson stems
Fix biome colouring for stem blocks
+ Make the atlas wider to reduce the crazy height of the png + Clean up blockstates
It's a dirty little hack to do this in the Dockerfile, but for now this means the end of my yak shaving.
Apply a temporary fix to one of the dependencies and fix the grass_path block problem
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Here is my PR for the 1.14 blockstates. It includes changes to accommodate:
I'm however not sure if for each one I took the right approach.
There's still the bell that doesn't display completely, only the frame is rendered at the moment.