Json object loads is sometimes bytes object fix.#4
Json object loads is sometimes bytes object fix.#4CasperVM wants to merge 1 commit intomapcrafter:masterfrom CasperVM:master
Conversation
|
Just because I'm curious, which version of Python are you running? |
|
It's weird that people seem to have problems with the different backends of the vispy framework I'm using for all the OpenGL stuff, vispy should handle this correctly. We should maybe open a separate issue for that and discuss how what hints etc. we should give to users make a proper installation of Blockcrafter easier. |
|
I've got a Blockcrafter docs page in the works, to step people through the install bits. FYI, I had PyQt5 and Pyglet working on Ubuntu 18.04 and Windows 10 + Python 3.7. I've seen various errors when Blockcrafter finishes rendering: stack traces are all about destructors and clean up. But the images / json files were still generated correctly. |
I do agree that we should definitely open a new issue on this, I do however want to note I have 0 experience in OpenGL stuff. I wouldn't mind learning this and helping to debug though :) Btw, the specific version I was running;
With the following libraries; |
There was an issue I had regarding blockcrafter;
I got weird errors that json.loads was expecting str not bytes, I fixed the issue with the following commit.
This happened when trying to make a blockset of texture size 6 for mc 1.13.
Also, another note; PyQt 4 and 5 give me segmentation faults, however, pyglet seems to work well. I tested this with python3.4, I am not sure if blockcrafter works for 3.5 anymore...