Fix/mlwmsloader #254
Merged
Fix/mlwmsloader #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR refactors WMS parameter handling to use normalized uppercase keys and reorganizes WMS-specific URL parameters into separate categories (base, GetCapabilities, GetMap, GetFeatureInfo). It also enhances the MlMarker component with improved styling and a close button feature.
Changes:
- Introduced a
normalizeWmsParamsutility function to standardize WMS parameter keys to uppercase - Refactored WMS URL parameters into separate categories for different request types
- Enhanced MlMarker component with dynamic sizing, improved styling, and an optional close button
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-maplibre/src/utils/wmsUtils.ts | New utility file containing normalizeWmsParams function for WMS parameter normalization |
| packages/react-maplibre/src/hooks/useWms.ts | Updated to use normalizeWmsParams and added debug console.log |
| packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.tsx | Refactored to use separate URL parameter categories and apply normalization throughout |
| packages/react-maplibre/src/components/MlWmsLayer/MlWmsLayer.tsx | Updated to use normalizeWmsParams for parameter handling |
| packages/react-maplibre/src/components/MlMarker/MlMarker.tsx | Enhanced with close button, dynamic width calculation, and improved iframe styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-maplibre/src/components/MlWmsLoader/MlWmsLoader.tsx
Outdated
Show resolved
Hide resolved
…utton positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.