Skip to content

Conversation

@acalcutt
Copy link
Contributor

@acalcutt acalcutt commented May 7, 2025

This PR updates the abi_crosswalk.json in the repo to support node 24 / ABI 137

This technically gets updated as part of a release, but I think it it good to update it in the repo as well.

@acalcutt acalcutt requested a review from a team as a code owner May 7, 2025 01:11
Copy link
Collaborator

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!!

@cclauss cclauss merged commit 7253455 into mapbox:master May 7, 2025
20 checks passed
@acalcutt
Copy link
Contributor Author

acalcutt commented May 7, 2025

I can make a PR for a release soon so we can get one with this included if you would like, maybe like a 2.0.1 release. I plan to try and make a node v24 release soon in my project, once NaN support and this is updated, so it would be helpful to have it included.

The only thing I meant to ask about was the lts/* in the ci. Right now that seems to resolve to node 22, so I added 24.x in the list, but i would imagine eventually that will be lts/* also. it might be better to just have 20.x, 22.x, and 24.x

@cclauss
Copy link
Collaborator

cclauss commented May 8, 2025

A new release makes sense to me.

The reason that I would like to keep lts/* is because this repo has few maintainers and has sat unmaintained for long periods of time, and it would be better to have proof of broken new LTS versions than have them be silently broken.

As a reminder, Node.js 24 will enter long-term support (LTS) in October, but until then, it will be the "Current" release for the next six months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants