Skip to content

Plugin should use debug() instead of log() for debug-output. #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gennadiylitvinyuk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Plugin should use debug() instead of log() for debug-output. #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions jquery.cycle.all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,14 @@ $.fn.cycle = function(options, arg2) {
// in 1.3+ we can fix mistakes with the ready state
if (this.length === 0 && options != 'stop') {
if (!$.isReady && o.s) {
log('DOM not ready, queuing slideshow');
debug('DOM not ready, queuing slideshow');
$(function() {
$(o.s,o.c).cycle(options,arg2);
});
return this;
}
// is your DOM ready? http://docs.jquery.com/Tutorials:Introducing_$(document).ready()
log('terminating; zero elements found by selector' + ($.isReady ? '' : ' (DOM not ready)'));
debug('terminating; zero elements found by selector' + ($.isReady ? '' : ' (DOM not ready)'));
return this;
}

Expand All @@ -72,7 +72,7 @@ $.fn.cycle = function(options, arg2) {
var els = $slides.get();

if (els.length < 2) {
log('terminating; too few slides: ' + els.length);
debug('terminating; too few slides: ' + els.length);
return;
}

Expand Down Expand Up @@ -145,7 +145,7 @@ function handleArguments(cont, options, arg2) {
case 'next':
opts = $(cont).data('cycle.opts');
if (!opts) {
log('options not found, "prev/next" ignored');
debug('options not found, "prev/next" ignored');
return false;
}
if (typeof arg2 == 'string')
Expand All @@ -162,11 +162,11 @@ function handleArguments(cont, options, arg2) {
var num = options;
options = $(cont).data('cycle.opts');
if (!options) {
log('options not found, can not advance slide');
debug('options not found, can not advance slide');
return false;
}
if (num < 0 || num >= options.elements.length) {
log('invalid slide index: ' + num);
debug('invalid slide index: ' + num);
return false;
}
options.nextSlide = num;
Expand All @@ -185,7 +185,7 @@ function handleArguments(cont, options, arg2) {
if (!isPaused && arg2 === true) { // resume now!
var options = $(cont).data('cycle.opts');
if (!options) {
log('options not found, can not resume');
debug('options not found, can not resume');
return false;
}
if (cont.cycleTimeout) {
Expand Down Expand Up @@ -405,13 +405,13 @@ function buildOptions($cont, $slides, els, options, o) {
// don't requeue for images that are still loading but have a valid size
if (loading) {
if (o.s && opts.requeueOnImageNotLoaded && ++options.requeueAttempts < 100) { // track retry count so we don't loop forever
log(options.requeueAttempts,' - img slide not loaded, requeuing slideshow: ', this.src, this.cycleW, this.cycleH);
debug(options.requeueAttempts,' - img slide not loaded, requeuing slideshow: ', this.src, this.cycleW, this.cycleH);
setTimeout(function() {$(o.s,o.c).cycle(options);}, opts.requeueTimeout);
requeue = true;
return false; // break each loop
}
else {
log('could not determine size of image: '+this.src, this.cycleW, this.cycleH);
debug('could not determine size of image: '+this.src, this.cycleW, this.cycleH);
}
}
}
Expand Down Expand Up @@ -467,7 +467,7 @@ function buildOptions($cont, $slides, els, options, o) {
if ($.isFunction(init))
init($cont, $slides, opts);
else if (opts.fx != 'custom' && !opts.multiFx) {
log('unknown transition: ' + opts.fx,'; slideshow terminating');
debug('unknown transition: ' + opts.fx,'; slideshow terminating');
return false;
}
}
Expand Down Expand Up @@ -514,14 +514,14 @@ function supportMultiTransitions(opts) {
var fx = opts.fxs[i];
tx = txs[fx];
if (!tx || !txs.hasOwnProperty(fx) || !$.isFunction(tx)) {
log('discarding unknown transition: ',fx);
debug('discarding unknown transition: ',fx);
opts.fxs.splice(i,1);
i--;
}
}
// if we have an empty list then we threw everything away!
if (!opts.fxs.length) {
log('No valid transitions named; slideshow terminating.');
debug('No valid transitions named; slideshow terminating.');
return false;
}
}
Expand Down