Skip to content

Bug: Fix modules dropdown height inconsistency(#8635)#8637

Open
Mananpatel08 wants to merge 1 commit intomakeplane:previewfrom
Mananpatel08:fix/modules-dropdown-height
Open

Bug: Fix modules dropdown height inconsistency(#8635)#8637
Mananpatel08 wants to merge 1 commit intomakeplane:previewfrom
Mananpatel08:fix/modules-dropdown-height

Conversation

@Mananpatel08
Copy link

@Mananpatel08 Mananpatel08 commented Feb 16, 2026

Description

Adjusted dropdown height styling for Modules field to match other fields like Due date and Cycle, ensuring consistent UI alignment.

Type of Change

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Improvement (change that would cause existing functionality to not work as expected)
  • Code refactoring
  • Performance improvements
  • Documentation update

Screenshots and Media (if applicable)

Screenshot from 2026-02-16 18-08-45

Test Scenarios

  • Tested locally in development environment
  • Verified consistent height across all dropdown fields

References

Fixes #8635

Summary by CodeRabbit

  • Style
    • Updated button container dimensions in the module select interface.

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 16, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Modified the module-select component to increase the button container height by adding the h-7.5 utility class and adjusted the onChange handler to wrap the module change callback with async void casting, addressing height inconsistency with other dropdown fields.

Changes

Cohort / File(s) Summary
Module Select Component
apps/web/core/components/issues/issue-detail/module-select.tsx
Increased button container height (added h-7.5 class) to match other dropdown fields. Refactored onChange handler to wrap handleIssueModuleChange callback with void cast for async handling. Simplified imports to include only useState.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A button grows just slightly taller,
No longer small, but standing squaller!
With h-7.5 in the mix so right,
The dropdowns dance in perfect height! ✨

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the bug fix for modules dropdown height inconsistency and references the issue number, accurately reflecting the main change.
Description check ✅ Passed The PR description follows the template with all required sections completed: description, type of change (bug fix), screenshots, test scenarios, and references to issue #8635.
Linked Issues check ✅ Passed The PR successfully addresses the styling change required by issue #8635: adjusting the Modules dropdown height to match other fields like Due date and Cycle.
Out of Scope Changes check ✅ Passed The changes are focused on the module-select component styling and remain within scope of fixing the dropdown height inconsistency outlined in issue #8635.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into preview

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Mananpatel08
Copy link
Author

Hi maintainers, I’ve fixed the modules dropdown height inconsistency and verified it locally. Please let me know if any changes are needed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Modules dropdown height inconsistent with other fields in issue details panel

2 participants