-
Notifications
You must be signed in to change notification settings - Fork 1
Product Menu aligning. + fixed paddingScale warning #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/lib/components/navigation/cspr-products-menu/products-menu-item.tsx
Outdated
Show resolved
Hide resolved
davidatwhiletrue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test changing the flex property on CSPR.live and the items disalign
https://github.com/user-attachments/assets/c5274ae3-206c-4f57-962c-47674804fef3
davidatwhiletrue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Fixed paddingScale warning message in dev console. By make it transient props
Type of Change
Component(s) Affected
TooltipChanges Made
Replaced
paddingScalewith$paddingScaleto avoid adding it into DOM direcltyTesting
Storybook
Breaking Changes
Yes. We need to update all usages of Tooltip component
Screenshots/Videos
TODO
Checklist