Added season search for TmdbAPI #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored TMDBSeasonAPI to improve API calls and data handling. I also added metadata from the main series that is missing in the season details (actors, writers, genre,...) this might be inaccurate for some seasons however but there's no other option
You can now search for a series, select it and it'll list all the seasons for that series. With the new modal you can then select the seasons you want to add.
Owner
mProjectsCode
left a comment
mProjectsCode
left a comment
There was a problem hiding this comment.
It would also be nice if you could add types for the API responses, similar to the other APIs.
| return; | ||
| } | ||
|
|
||
| // Only show the season select modal if the user searches for seasons |
Owner
There was a problem hiding this comment.
I think it would be better if some of this code were to be put in a new method, to keep this method short and readable.
Contributor
Author
There was a problem hiding this comment.
Is it alright like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is separate from the series search so users can choose which to use or use both if they want to. It only works with tmdbAPI and here is how it looks
Step 1:
Step 2:
Step 3:
Note that if you try to add multiple series it won't work, only choose one series in the series modal and then as many seasons as you want in the season modal.
I used @ZackBoe's tmdb PR as a base.