Addition of function to allow for object params#2
Open
neildcuk wants to merge 2 commits intolow:masterfrom
Open
Addition of function to allow for object params#2neildcuk wants to merge 2 commits intolow:masterfrom
neildcuk wants to merge 2 commits intolow:masterfrom
Conversation
This method allows for the use of object-based parameters when fetching block data. Feel free to rewrite into the class if you think it adversely affects the workings of the id() method!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I've found this function useful on a site we've built - it essentially lets you build up a params object and use it as an object instead of chaining methods into blocks(). Example template use below:
Seems to work well enough for us - although I'm not sure what the
idmethod is for and whether or not bypassing$this->criteriafor the new method will cause a problem. Either way, feel free to either pull or implement in your own way - would appreciate you letting us know if you manage to do this without the extra method or you change its name!