Skip to content

Conversation

@Polliog
Copy link
Collaborator

@Polliog Polliog commented Feb 2, 2026

This pull request updates several backend API endpoints and their corresponding frontend calls to consistently accept the organizationId parameter in the request body (preferred) instead of the query string, improving API design and forward compatibility. Additionally, it introduces batching for identifier lookups to respect API limits and ensures POST requests include an empty body where required.

API Request Parameter Handling:

  • Updated backend endpoints in detection-packs/routes.ts and notification-channels/routes.ts to accept organizationId from the request body (preferred) or query string (legacy), with improved error messaging. [1] [2]
  • Updated frontend API methods (DetectionPacksAPI.disablePack, notificationChannelsAPI.test) to send organizationId in the POST request body instead of as a query parameter. [1] [2]

Batching and Performance Improvements:

  • Enhanced the CorrelationAPI.getIdentifiersForLogIds method to batch requests in groups of 100 log IDs and merge results, improving scalability and respecting API limits.

Request Consistency:

  • Ensured POST requests in AdminAuthAPI.testConnection, InvitationsAPI.resendInvitation, and OrganizationsAPI.leaveOrganization include an empty body for consistency and future-proofing. [1] [2] [3]

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 89.88764% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/backend/src/server.ts 68.75% 5 Missing ⚠️
packages/backend/src/modules/ingestion/routes.ts 90.62% 3 Missing ⚠️
packages/backend/src/modules/ingestion/service.ts 95.45% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Polliog Polliog merged commit 38cad46 into main Feb 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants