[libc++][iterator] Applied [[nodiscard]]
#172200
Draft
+479
−129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H-G-Hristov
force-pushed
the
hgh/libcxx/nodiscard-to-iterators
branch
from
aef92a8 to
15bf252
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
H-G-Hristov
force-pushed
the
hgh/libcxx/nodiscard-to-iterators
branch
4 times, most recently
from
e252dd0 to
16806f9
Compare
`[[nodiscard]]` should be applied to functions where discarding the return value is most likely a correctness issue. - https://libcxx.llvm.org/CodingGuidelines.htm - https://wg21.link/iterators Towards llvm#172124
H-G-Hristov
force-pushed
the
hgh/libcxx/nodiscard-to-iterators
branch
from
16806f9 to
7061781
Compare
Zingam
reviewed
Dec 15, 2025
Comment on lines
-215
to
+222
| _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 | ||
| [[__nodiscard__]] _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX14 | ||
| #ifndef _LIBCPP_CXX03_LANG | ||
| auto | ||
| operator-(const __wrap_iter<_Iter1>& __x, | ||
| const __wrap_iter<_Iter2>& __y) _NOEXCEPT->decltype(__x.base() - __y.base()) | ||
| auto operator-(const __wrap_iter<_Iter1>& __x, | ||
| const __wrap_iter<_Iter2>& __y) _NOEXCEPT->decltype(__x.base() - __y.base()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[nodiscard]]should be applied to functions where discarding the return value is most likely a correctness issue.Towards #172124