[HWASan] Compatible with Windows path retrieval #172194
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
compiler-rt
compiler-rt:hwasan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: None (GkvJwa) ChangesFix #134853 Since the Windows path separator is typically Full diff: https://github.com/llvm/llvm-project/pull/172194.diff 1 Files Affected:
diff --git a/compiler-rt/lib/hwasan/scripts/hwasan_symbolize b/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
index 19d948d1f0aaa..efc7c868696c3 100755
--- a/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
+++ b/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
@@ -476,7 +476,7 @@ def main():
# Source location.
paths_to_cut = args.source or []
if not paths_to_cut:
- paths_to_cut.append(os.getcwd() + '/')
+ paths_to_cut.append(os.getcwd().replace('\\', '/') + '/')
if 'ANDROID_BUILD_TOP' in os.environ:
paths_to_cut.append(os.environ['ANDROID_BUILD_TOP'] + '/')
|
Contributor
Author
cjappl
reviewed
Dec 14, 2025
| paths_to_cut = args.source or [] | ||
| if not paths_to_cut: | ||
| paths_to_cut.append(os.getcwd() + '/') | ||
| paths_to_cut.append(os.getcwd().replace('\\', '/') + '/') |
Contributor
There was a problem hiding this comment.
If this is python3, can we just use pathlib? I think they deal with the platform specific separators in a nice abstracted way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #134853
Since the Windows path separator is typically
\\, replace it with/.