[orc-rt] Ensure EH/RTTI=On overrides LLVM opts, applies to unit tests. #172155
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When -DORC_RT_ENABLE_EXCEPTIONS=On and -DORC_RT_ENABLE_RTTI=On are passed we need to ensure that the resulting compiler flags (e.g. -fexceptions, -frtti for clang/GCC) are appended so that we override any inherited options (e.g. -fno-exceptions, -fno-rtti) from LLVM. Updates unit tests to ensure that these compiler options are applied to them too.
lhames
force-pushed
the
orc-rt-eh-rtti-unittests
branch
from
3631ded to
5f8fe07
Compare
jaredwy
reviewed
Dec 14, 2025
| span-test.cpp | ||
| DISABLE_LLVM_LINK_LLVM_DYLIB | ||
| ) | ||
| target_compile_options(CoreTests PRIVATE ${ORC_RT_COMPILE_FLAGS}) |
Contributor
There was a problem hiding this comment.
We could instead use the CXX_RTTI and CXX_EXCEPTIONS properties here, and do the checks here instead of inside the the header. This is more akin to how a library consumer would compile the orc-rt.
These are cross platform and will work on windows (but we don't have that supported yet)
Contributor
There was a problem hiding this comment.
set_target_properties(CoreTests PROPERTIES
CXX_RTTI ${ORC_RT_ENABLE_RTTI}
CXX_EXCEPTIONS ${ORC_RT_ENABLE_EXCEPTIONS}
)
something like this should work, but you would also need to ensure its on the executor etc
Contributor
There was a problem hiding this comment.
It look like these are unique to a previous project.
Feel free to merge and ill introduce these later when I add windows support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When -DORC_RT_ENABLE_EXCEPTIONS=On and -DORC_RT_ENABLE_RTTI=On are passed we need to ensure that the resulting compiler flags (e.g. -fexceptions, -frtti for clang/GCC) are appended so that we override any inherited options (e.g. -fno-exceptions, -fno-rtti) from LLVM.
Updates unit tests to ensure that these compiler options are applied to them too.