Merging scalar wave solver support files#1387
Open
chvillanuevap wants to merge 2 commits intodevelopfrom
Open
Conversation
tupek2
reviewed
May 23, 2025
| * @param cycle The cycle to retrieve state from | ||
| * @return A map containing the primal field names and their associated FiniteElementStates at the requested cycle | ||
| */ | ||
| std::unordered_map<std::string, FiniteElementState> getCheckpointedStates(int cycle); |
Collaborator
There was a problem hiding this comment.
I'm confused by this change? We have other tests that use loadCheckpointedState(const std::string& state_name, int cycle), which is public. Why not use that?
tupek2
reviewed
Jun 2, 2025
| auto scalar_coef = get<std::shared_ptr<mfem::Coefficient>>(coef_); | ||
| scalar_coef->SetTime(time); | ||
| if (component_) { | ||
| if (component_ || attr_markers_.Size() == 0) { // TODO: If attribute markers is empty, that means this is applied to the entire domain (component could be zero). |
Collaborator
There was a problem hiding this comment.
why is this needed? was there a bug?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch includes supporting changes required for the scalar wave solver: