Open
Conversation
Collaborator
Author
|
Found a failure case. Hold off on review for now. |
rountree
requested a deployment
to
Spindle CI
GitHub Actions
In progress
Previously, chosen_realized_cachepath was copied into set_intercept_readlink_cachepath() chosen_realized_cachepath and chosen_parsed_cachepath were copied into set_should_intercept_cachepath() This PR removes both setter functions and makes the original pointers global.
Removes chosen_cachepath and cachepath_bitindex from spindle_launch.h Updates initialization of matching variables in ldcs_process_data. determineValidCachePaths() moved from spindle_be.cc to ldcs_audit_server_process.c to get ldcs_process_data visibility. Added #include "parseloc.h" to ldcs_audit_server_process.c to get declaration of determineValidCachePaths(). Relocated "parseloc.h" to src/util so ldcs_audit_server_process.c could find it. Trued up signedness of types caused my making "parseloc.h" more visible, e.g., cachepath_bitidx is now uint64_t everywhere.
The three-message-reply response is now a single message with two strings. The symbolic version of the cachepath is no longer communicated as it was not being used.
New name is ldcs_audit_server_md_allreduce_AND(). If we get to the point where we're using other allreduce operations we can solve the problem of duplicating the op list in md-land and cobo-land. For now, we're only using one op in md-land, so the op can go into the function name.
rountree
had a problem deploying
to
Spindle CI
GitHub Actions
Failure
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.11.1 to 3.12.0. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@e468171...8d2750c) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: 3.12.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@1af3b93...8e8c483) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Additionally populates /etc/environment just in case ssh is used to set up the servers.
nchaimov
reviewed
Feb 5, 2026
| enable_maintainer_mode | ||
| with_default_port | ||
| with_default_num_ports | ||
| with_localstorage |
Collaborator
There was a problem hiding this comment.
The configure script will give a warning for unrecognized arguments, so removing the --with-localstorage causes builds that still specify --with-localstorage to configure without error, but the option is unused. For example, the script in the CI environment that builds Spindle uses --with-localstorage=/tmp, and you can see the warning in the CI output:
#18 0.165 configure: WARNING: unrecognized options: --with-localstorage
https://github.com/llnl/Spindle/actions/runs/21076617750/job/60620001124?pr=117#step:4:826
I wonder if it would make sense to either:
- Give an error rather than a warning if
--with-localstorageis specified, where the error message says that--with-cachepathsand--with-commpathshould be used instead; or, - Still accept
--with-localstorageand use it to set the cachepaths and commpath value.
We should also change the Spindle configure line used in CI to use the new arguments instead of --with-localstorage, in containers/spindle-serial-ubuntu/scripts/build_spindle.sh, containers/spindle-flux-ubuntu/scripts/build_spindle.sh, and containers/spindle-slurm-ubuntu/testing/scripts/build_spindle.sh.
Comment on lines
+1286
to
+1290
| // Ignore Spindle fifo files for now. | ||
| if ( strncmp( "315", d->d_name, 3 ) == 0 ) | ||
| continue; | ||
| if ( strncmp( "316", d->d_name, 3 ) == 0 ) | ||
| continue; |
Collaborator
There was a problem hiding this comment.
Where do these numbers (315, 316) come from?
| @@ -0,0 +1 @@ | |||
| Hello, world! | |||
Collaborator
There was a problem hiding this comment.
I think this was just added to force the CI to run and should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
locationenvironment variables, fields, and enums tocommpath.Builds with --with-rm=[flux|serial|slurm]. Can't build slurm-plugin, but that's not due to these changes.