fix: useMultibandTrackVolume clipping #1265
Merged
+19
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Depending on the # of audio bands, there is a strange clipping (low-pass filter) effect on the visualizer
Math.ceil-based chunking causes trailing bands to be zeroed outloPass/hiPassoptions are not using merged defaultsScreen.Recording.2026-01-13.at.6.22.06.PM.mov
Explaination
We initially fill an array of "bins" with zeros, then we process the frequency bands.
Proportional filling tries to optimize for filling all the bins while processing all frequencies
Solution
loPass/hiPassoptions from merged defaultsScreen.Recording.2026-01-13.at.9.00.57.PM.mov
Test plan
pnpm dev:storybookand reviewe the various visualizersspeakingbandsbeing renderedChecklist
bandscountbandsvalues (5, 7, 10, 20, 50) to ensure consistent behavior