[WIP] Update Menu on Status Update#139
Open
NPScript wants to merge 2 commits intolinuxmint:masterfrom
Open
Conversation
clefebvre
changed the title
Member
|
I'm not against this, but it's malformed.. you've mixed in more than the fix in this PR. I see code cleanup, the fix itself and a move to AppIndicator. I'm interested in knowing who still uses blueberry, with what version of GNOME BT, and whether it's in Wayland or Xorg. Come and chat with us on Matrix if you get a chance: https://matrix.to/#/#xapp:matrix.org Blueberry is no longer used in Mint but if other people use it we can revive this project and see how to maintain it going forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem in the current
blueberry-tray.pythat theTurn off Bluetoothbutton does not change toTurn on Bluetoothsince the menu is only built once and never updated.
This problem is resolved by moving the
set_menucall into theupdate_icon_callback. With this the menu will always be updated when the Bluetooth status changes.I also merged the following patch into my branch: libappindicator-patch.
This will allow
blueberry-trayto also run under Wayland.