-
Notifications
You must be signed in to change notification settings - Fork 34
refactor: Service safety rectification #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @wangrong1069, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
- Replace com.deepin.diskmanager policy with com.deepin.pkexec.deepin-diskmanager - Update all translation files to reflect new policy filename - Modify CMakeLists.txt to use deepin-policy-ts-convert for policy file generation - Update desktop file handling with deepin-desktop-ts-convert - Change authorization check in diskmanagerservice.cpp to use new action ID - Update debian/control to include pkexec dependency and deepin-gettext-tools - Fix installation paths for USB scripts from openconnect to deepin-diskmanager - Remove hardcoded translations from policy file, rely on translation system - Update DBus configuration to remove own policy requirement This migration improves security and follows modern authentication best practices.
deepin pr auto review我来分析一下这个 Git diff 的内容,主要涉及许可证文件格式更新、构建系统修改和权限策略调整。
总体建议:
没有发现明显的性能问题或安全隐患。改动主要涉及构建和部署流程的优化。 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: unstable) |
This migration improves security and follows modern authentication best practices.