-
Notifications
You must be signed in to change notification settings - Fork 34
fix: Fix non-reproducible builds #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skip build rpath when the build type is set to "Release" to ensure reproducible builds.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates the CMake configuration to disable setting the build rpath when building in Release mode, ensuring reproducible release builds. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review我来对这个CMakeLists.txt的修改进行审查:
改进建议:
# Skip build rpath for reproducible release build
# Note: This may affect runtime library search path
# Ensure all necessary libraries are in standard system paths
if(CMAKE_BUILD_TYPE STREQUAL "Release")
set(CMAKE_SKIP_BUILD_RPATH TRUE)
endif()
# Add option to control RPATH behavior
option(SKIP_RPATH_IN_RELEASE "Skip RPATH in Release builds" ON)
if(CMAKE_BUILD_TYPE STREQUAL "Release" AND SKIP_RPATH_IN_RELEASE)
set(CMAKE_SKIP_BUILD_RPATH TRUE)
endif()
if(CMAKE_BUILD_TYPE STREQUAL "Release" AND NOT CMAKE_CROSSCOMPILING)
set(CMAKE_SKIP_BUILD_RPATH TRUE)
endif()这些改进可以让代码更加健壮和可配置,同时提供更好的文档说明。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, wangrong1069 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Skip build rpath when the build type is set to "Release" to ensure reproducible builds.
Summary by Sourcery
Build: