-
Notifications
You must be signed in to change notification settings - Fork 16
fix: fix treeland-protocols name #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should work as intended
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Treeland Wayland registry binding to use the correct protocol interface name Sequence diagram for updated Treeland Wayland registry bindingsequenceDiagram
participant WaylandRegistry as wl_registry
participant TreelandConnector as TreelandConnector
participant TreelandDDM as treeland_ddm_v1
WaylandRegistry->>TreelandConnector: registerGlobal(data, registry, name, interface, version)
TreelandConnector->>TreelandConnector: strcmp(interface, treeland_ddm_v1)
alt interface matches treeland_ddm_v1
TreelandConnector->>WaylandRegistry: wl_registry_bind(registry, name, treeland_ddm_v1_interface, version)
WaylandRegistry-->>TreelandConnector: treeland_ddm_v1 object
TreelandConnector->>TreelandDDM: use treeland_ddm_v1 listener treelandDDMListener
else interface does not match
TreelandConnector-->>WaylandRegistry: ignore global
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Hi @calsys456. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: calsys456, zccrs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This should work as intended
Summary by Sourcery
Bug Fixes: