Skip to content

Conversation

@calsys456
Copy link
Contributor

@calsys456 calsys456 commented Jan 15, 2026

This should work as intended

Summary by Sourcery

Bug Fixes:

  • Correct the Treeland Wayland registry binding to use the treeland_ddm_v1 interface name instead of the outdated treeland_ddm identifier.

This should work as intended
@sourcery-ai
Copy link

sourcery-ai bot commented Jan 15, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Treeland Wayland registry binding to use the correct protocol interface name treeland_ddm_v1 instead of treeland_ddm, ensuring it binds to the proper versioned protocol.

Sequence diagram for updated Treeland Wayland registry binding

sequenceDiagram
    participant WaylandRegistry as wl_registry
    participant TreelandConnector as TreelandConnector
    participant TreelandDDM as treeland_ddm_v1

    WaylandRegistry->>TreelandConnector: registerGlobal(data, registry, name, interface, version)
    TreelandConnector->>TreelandConnector: strcmp(interface, treeland_ddm_v1)
    alt interface matches treeland_ddm_v1
        TreelandConnector->>WaylandRegistry: wl_registry_bind(registry, name, treeland_ddm_v1_interface, version)
        WaylandRegistry-->>TreelandConnector: treeland_ddm_v1 object
        TreelandConnector->>TreelandDDM: use treeland_ddm_v1 listener treelandDDMListener
    else interface does not match
        TreelandConnector-->>WaylandRegistry: ignore global
    end
Loading

File-Level Changes

Change Details Files
Correct Wayland protocol interface string used when binding the treeland_ddm_v1 global.
  • Adjusts the interface name comparison in the Wayland registry global handler to match treeland_ddm_v1.
  • Keeps the existing bind call targeting treeland_ddm_v1_interface, aligning the string check with the bound interface type.
src/daemon/TreelandConnector.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-ci-robot
Copy link

Hi @calsys456. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: calsys456, zccrs

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zccrs zccrs merged commit e86887a into linuxdeepin:master Jan 15, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants