-
Notifications
You must be signed in to change notification settings - Fork 2
[PW_SID:1045497] regulator: spacemit-p1: Fix voltage ranges and support board power tree #1367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: workflow__riscv__fixes
Are you sure you want to change the base?
Conversation
Higher voltage settings were unusable due to incorrect n_voltages values causing registration failures. For example, setting aldo4 to 3.3V failed with -EINVAL because the required selector (123) exceeded the allowed range (n_voltages=117). Fix by aligning n_voltages with the hardware register widths per the P1 datasheet [1]: - BUCK: 255 (was 254), allows selectors 0-254, selector 255 is reserved - LDO: 128 (was 117), allows selectors 0-127, selectors 0-10 are for suspend mode, valid operational range is 11-127 This enables the full voltage range supported by the hardware. Fixes: 8b84d71 ("regulator: spacemit: support SpacemiT P1 regulators") Link: https://developer.spacemit.com/documentation [1] Signed-off-by: Guodong Xu <guodong@riscstar.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
…ties Add supply properties that match the P1 PMIC's actual hardware topology where each buck converter has its own VIN pin and LDO groups share common input pins. Supply names are defined according to the pinout names in the P1 datasheet. This allows different boards to describe their actual power tree connections in devicetree rather than hardcoding supply relationships in the driver. Signed-off-by: Guodong Xu <guodong@riscstar.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Update supply names to match the P1 PMIC's actual hardware pinout where each buck has an individual VIN pin (vin1-vin6) and LDO groups have dedicated input pins (aldoin, dldoin1, dldoin2). The supply is a board design decision and should not be hardcoded to any existing power source. This allows boards to specify their actual power tree topology in devicetree. Signed-off-by: Guodong Xu <guodong@riscstar.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
Update individual supply properties in pmic node to accurately specify the board's power tree topology. Previously these relationships were hardcoded in the driver; now they are explicitly defined in the devicetree per the updated binding document spacemit,p1.yaml. Signed-off-by: Guodong Xu <guodong@riscstar.com> Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 1: "[1/4] regulator: spacemit-p1: Fix n_voltages for BUCK and LDO regulators" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 2: "[2/4] dt-bindings: mfd: spacemit,p1: Add individual regulator supply properties" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 3: "[3/4] regulator: spacemit-p1: Update supply names" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
|
Patch 4: "[4/4] riscv: dts: spacemit: k1-bananapi-f3: Update PMIC supply properties" |
PR for series 1045497 applied to workflow__riscv__fixes
Name: regulator: spacemit-p1: Fix voltage ranges and support board power tree
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1045497
Version: 1