Skip to content

Conversation

@linux-riscv-bot
Copy link

PR for series 1045085 applied to workflow__riscv__fixes

Name: crypto: aegis128: Add RISC-V vector SIMD implementation
URL: https://patchwork.kernel.org/project/linux-riscv/list/?series=1045085
Version: 1

Add a RISC-V vector-accelerated implementation of aegis128 by
wiring it into the generic SIMD hooks.

This implementation supports vlen values of 512, 256, and 128.

Signed-off-by: Chunyan Zhang <zhangchunyan@iscas.ac.cn>
Signed-off-by: Linux RISC-V bot <linux.riscv.bot@gmail.com>
@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
build-rv32-defconfig
Desc: Builds riscv32 defconfig
Duration: 115.02 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
build-rv64-clang-allmodconfig
Desc: Builds riscv64 allmodconfig with Clang, and checks for errors and added warnings
Duration: 1236.96 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
build-rv64-gcc-allmodconfig
Desc: Builds riscv64 allmodconfig with GCC, and checks for errors and added warnings
Duration: 1565.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
build-rv64-nommu-k210-defconfig
Desc: Builds riscv64 defconfig with NOMMU for K210
Duration: 25.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
build-rv64-nommu-k210-virt
Desc: Builds riscv64 defconfig with NOMMU for the virt platform
Duration: 26.35 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
checkpatch
Desc: Runs checkpatch.pl on the patch
Duration: 3.96 seconds
Result: WARNING
Output:

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#55: 
new file mode 100644

CHECK: Alignment should match open parenthesis
#73: FILE: crypto/aegis-rvv.h:14:
+void crypto_aegis128_encrypt_chunk_rvv(void *state, void *dst, const void *src,
+					unsigned int size);

CHECK: Alignment should match open parenthesis
#75: FILE: crypto/aegis-rvv.h:16:
+void crypto_aegis128_decrypt_chunk_rvv(void *state, void *dst, const void *src,
+					unsigned int size);

CHECK: Alignment should match open parenthesis
#77: FILE: crypto/aegis-rvv.h:18:
+int crypto_aegis128_final_rvv(void *state, void *tag_xor,
+			       unsigned int assoclen,

CHECK: Concatenated strings should use spaces between elements
#115: FILE: crypto/aegis128-rvv-inner.c:29:
+		      "vsetvli	%0, x0, e8, "m", ta, ma\n"	\

CHECK: Concatenated strings should use spaces between elements
#116: FILE: crypto/aegis128-rvv-inner.c:30:
+		      "vle8.v	"r0", (%1)\n"			\

CHECK: Concatenated strings should use spaces between elements
#129: FILE: crypto/aegis128-rvv-inner.c:43:
+		      "vsetvli	%0, x0, e8, "m", ta, ma\n"	\

CHECK: Concatenated strings should use spaces between elements
#130: FILE: crypto/aegis128-rvv-inner.c:44:
+		      "vle8.v	"r0", (%1)\n"			\

CHECK: Concatenated strings should use spaces between elements
#131: FILE: crypto/aegis128-rvv-inner.c:45:
+		      "vle8.v	"r1", (%2)\n"			\

CHECK: Please don't use multiple blank lines
#195: FILE: crypto/aegis128-rvv-inner.c:109:
+
+

CHECK: Concatenated strings should use spaces between elements
#229: FILE: crypto/aegis128-rvv-inner.c:143:
+	"vrgather.vv	v3, "r", v1\n"		\

CHECK: Alignment should match open parenthesis
#456: FILE: crypto/aegis128-rvv-inner.c:370:
+void crypto_aegis128_encrypt_chunk_rvv(void *state, void *dst, const void *src,
+					unsigned int size)

CHECK: multiple assignments should be avoided
#537: FILE: crypto/aegis128-rvv-inner.c:451:
+			in = out = memcpy(buf + AEGIS_BLOCK_SIZE - size, src, size);

CHECK: Alignment should match open parenthesis
#598: FILE: crypto/aegis128-rvv-inner.c:512:
+void crypto_aegis128_decrypt_chunk_rvv(void *state, void *dst, const void *src,
+					unsigned int size)

CHECK: multiple assignments should be avoided
#677: FILE: crypto/aegis128-rvv-inner.c:591:
+			in = out = memcpy(buf + AEGIS_BLOCK_SIZE - size, src, size);

CHECK: Alignment should match open parenthesis
#741: FILE: crypto/aegis128-rvv-inner.c:655:
+int crypto_aegis128_final_rvv(void *state, void *tag_xor,
+			       unsigned int assoclen,

CHECK: Alignment should match open parenthesis
#903: FILE: crypto/aegis128-rvv.c:59:
+	ret = crypto_aegis128_final_rvv(state, tag_xor, assoclen, cryptlen,
+					 authsize);

total: 0 errors, 1 warnings, 16 checks, 856 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Commit 9a9e5b90cd08 ("crypto: aegis128: Add RISC-V vector SIMD implementation") has style problems, please review.

NOTE: Ignored message types: ALLOC_SIZEOF_STRUCT CAMELCASE COMMIT_LOG_LONG_LINE GIT_COMMIT_ID MACRO_ARG_REUSE NO_AUTHOR_SIGN_OFF

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.
total: 0 errors, 1 warnings, 16 checks, 856 lines checked
CHECK: Alignment should match open parenthesis
CHECK: Concatenated strings should use spaces between elements
CHECK: Please don't use multiple blank lines
CHECK: multiple assignments should be avoided
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?


@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
dtb-warn-rv64
Desc: Checks for Device Tree warnings/errors
Duration: 80.70 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
header-inline
Desc: Detects static functions without inline keyword in header files
Duration: 0.23 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
kdoc
Desc: Detects for kdoc errors
Duration: 0.98 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
module-param
Desc: Detect module_param changes
Duration: 0.52 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
verify-fixes
Desc: Verifies that the Fixes: tags exist
Duration: 0.22 seconds
Result: PASS

@linux-riscv-bot
Copy link
Author

Patch 1: "crypto: aegis128: Add RISC-V vector SIMD implementation"
verify-signedoff
Desc: Verifies that Signed-off-by: tags are correct
Duration: 0.30 seconds
Result: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants