Dev/alex/cfi tests #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 16, 2025 11:28
Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
With a bunch of dirty workarounds Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
bjoto
requested changes
Apr 23, 2025
| RUN cd xfstests-dev && make CC=riscv64-linux-gnu-gcc LD=riscv64-linux-gnu-ld PKG_LIB_DIR=/build/xfstests install | ||
| RUN cd xfstests-dev && make CC=riscv64-linux-gnu-gcc LD=riscv64-linux-gnu-ld PKG_LIB_DIR=/build/xfstests install | ||
| RUN cd /build && tar --transform "s/build/\/opt/" -cJvf xfstests.tar.xz /build/xfstests | ||
| # FIXME python3:riscv64 overwrites host python3... |
Contributor
There was a problem hiding this comment.
Why do you need the python3 risc-v binary on the host?
Author
There was a problem hiding this comment.
That's a dependency of xfsprogs, needed to compile xfstests
| # cfi | ||
| # We need a cfi enabled toolchain, so let's build it | ||
| # Build fails for now, so instead use an already built toolchain un /build | ||
| # from here https://gitlab.ba.rivosinc.com/api/v4/projects/704/packages/generic/cfi_toolchain/sept2024/cfi_sept2024.tar.gz |
| RUN mkdir -p /build/cfi | ||
| COPY tests/cfi/main.c /build/cfi | ||
| WORKDIR /build/cfi | ||
| RUN riscv64-linux-gnu-gcc main.c -o not_cfi_compiled_should_fail -static |
Contributor
There was a problem hiding this comment.
clang nightly has support:
$ clang-21 -target riscv64 --print-supported-extensions|grep -i cfi
Ubuntu clang version 21.0.0 (++20250418083736+1db03cab70fd-1~exp1~20250418083753.380)
Target: riscv64
Thread model: posix
InstalledDir: /usr/lib/llvm-21/bin
zicfilp 1.0 'Zicfilp' (Landing pad)
zicfiss 1.0 'Zicfiss' (Shadow stack)
Maybe start with that instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.