types: add NVMe 2.3 opcode, fid and lid definitions #3025
+244
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikegami-t
force-pushed
the
nvme-2.3-def
branch
3 times, most recently
from
acd7603 to
f691b99
Compare
igaw
reviewed
Jan 2, 2026
nvme-print.c
Outdated
| case NVME_LOG_LID_MEDIA_UNIT_STATUS: | ||
| return "Media Unit Status"; | ||
| case NVME_LOG_LID_SUPPORTED_CAP_CONFIG_LIST: | ||
| return "Supported Capacity Configuration List"; |
Collaborator
There was a problem hiding this comment.
These two changes are unrelated to the change. Just whitespace changes. I suggest to keep the current formatting for this section consistent, so all in one line. Having different formatting styles is worse than the checkpatch warning.
Contributor
Author
There was a problem hiding this comment.
Fix the changes as mentioned. Thank you.
Collaborator
|
Please update the formatting, the rest looks good. |
Added for NVMe 2.3 commands support. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Supported by NVMe 2.3. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since the status code is duplicated with the fw-commit status code. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
nvme-2.3-def
branch
from
dc9e369 to
5493ea6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for NVMe 2.3 commands support.