Fix an error path in disk_update_zone_resources() #487
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: b543459 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
06634b5 to
8a473ad
Compare
Author
|
Upstream branch: 944aacb |
blktests-ci
bot
force-pushed
the
series/1042470=>linus-master
branch
from
53c4c3b to
10b6193
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
8a473ad to
fa94b37
Compare
Author
|
Upstream branch: 944aacb |
blktests-ci
bot
force-pushed
the
series/1042470=>linus-master
branch
from
10b6193 to
3388a7d
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
fa94b37 to
41a5848
Compare
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Any queue_limits_start_update() call must be followed either by a
queue_limits_commit_update() call or by a queue_limits_cancel_update()
call. Make sure that the error path near the start of
disk_update_zone_resources() follows this requirement. Remove the
"goto unfreeze" statement from that error path to make the code easier
to verify.
This was detected by annotating the queue_limits_*() calls with Clang
thread-safety attributes and by building the kernel with thread-safety
checking enabled. Without this patch and with thread-safety checking
enabled, the following error is reported:
block/blk-zoned.c:2020:1: error: mutex 'disk->queue->limits_lock' is not held on every path through here [-Werror,-Wthread-safety-analysis]
2020 | }
| ^
block/blk-zoned.c:1959:8: note: mutex acquired here
1959 | lim = queue_limits_start_update(q);
| ^
Cc: Damien Le Moal <dlemoal@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>
Fixes: bba4322 ("block: freeze queue when updating zone resources")
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Author
|
Upstream branch: 6c79021 |
blktests-ci
bot
force-pushed
the
series/1042470=>linus-master
branch
from
3388a7d to
eb017d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: Fix an error path in disk_update_zone_resources()
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1042470