ublk: fix ublksrv pid handling for pid namespaces #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 623fb99 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
f962a4d to
06634b5
Compare
Author
|
Upstream branch: b543459 |
blktests-ci
bot
force-pushed
the
series/1040786=>linus-master
branch
from
bb77e83 to
8760b36
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
06634b5 to
8a473ad
Compare
Author
|
Upstream branch: 944aacb |
blktests-ci
bot
force-pushed
the
series/1040786=>linus-master
branch
from
8760b36 to
df515cc
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
8a473ad to
fa94b37
Compare
Author
|
Upstream branch: 944aacb |
blktests-ci
bot
force-pushed
the
series/1040786=>linus-master
branch
from
df515cc to
00d934b
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
fa94b37 to
41a5848
Compare
Author
|
Upstream branch: 6c79021 |
blktests-ci
bot
force-pushed
the
series/1040786=>linus-master
branch
from
00d934b to
b4dbc17
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
41a5848 to
30680e5
Compare
Author
|
Upstream branch: a66191c |
When ublksrv runs inside a pid namespace, START/END_RECOVERY compared
the stored init-ns tgid against the userspace pid (getpid vnr), so the
check failed and control ops could not proceed. Compare against the
caller’s init-ns tgid and store that value, then translate it back to
the caller’s pid namespace when reporting GET_DEV_INFO so ublk list
shows a sensible pid.
Testing: start/recover in a pid namespace; `ublk list` shows
reasonable pid values in init, child, and sibling namespaces.
Fixes: d37a224fc119 ("ublk: validate ublk server pid")
Signed-off-by: Seamus Connor <sconnor@purestorage.com>
Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
blktests-ci
bot
force-pushed
the
series/1040786=>linus-master
branch
from
b4dbc17 to
de0bdb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: ublk: fix ublksrv pid handling for pid namespaces
version: 2
url: https://patchwork.kernel.org/project/linux-block/list/?series=1041446