Add charge mode setting for batteries #849
Conversation
Will try and set the charge type for all batteries detected Signed-off-by: Sven Willett <sven.willett@gmail.com>
Signed-off-by: Sven Willett <sven.willett@gmail.com>
|
@dingbat32 Thank you for your PR. You suggest implementing this as a generic feature without taking the actual underlying hardware into account. With your PR, the user would first have to check whether their hardware works with it and which values to use. But how can they find that out? The principles for TLP's battery care are different. Hardware dependencies and properties are encapsulated in plugins,
Yes, but unfortunately it's anything but uniform. The new "someday-maybe-standard" currently only exists for Lenovo (non-ThinkPads) [2] and Samsung (older models, not Galaxy Books) [3]. With Dell hardware, you write “Custom” and can then use charge_control_start/end_threshold in the conventional manner. For HP, however, there is nothing of the sort, as there is no kernel driver for it. However, with charge_control_start/end_threshold, there are different value for every vendor/brand, which are not shown to the user in sysfs. I have documented therm all in [1] and the corresponding pliugins enforce them. My suggestion: you integrate charge_types into the Lenovo plugin [4] as a case distinction. You have the hardware and can test it right away. Make sure to remain backward compatible, because not everyone has kernel 6.17 yet. For internal differentiation, the return value of _natacpi could be used, for example: 1=conservation_mode, 0=charge_types. Please base further PRs on my current battery care development branch bat.d/tlp.stat as long as I haven't merged it to main. [1] https://linrunner.de/tlp/settings/bc-vendors.html#lenovo-non-thinkpad-series |
|
ps. there is also #831 on this topic. |
2 participants
Adds the CHARGE_MODE setting that can be set to different options depending on your system.
On my Lenovo Legion, I can set it to Long_Life in order to limit the battery to 80% maximum charge. This uses the new charge_types property of the sysfs power supply class. This is equivalent to the old conservation_mode property, but has support for other hardware as well, such as with Dell or HP, although options may be different.
Not sure if I did everything correctly, but I think this a useful setting that I would like to see in TLP. I ran make checkall to check for any code issues, and did some testing on my system.